refactor(console): enable TypeScript strict mode - #835
Conversation
|
Hi @rh-gvincent. Thanks for your PR. I'm waiting for a validatedpatterns member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Set "strict": true in tsconfig.json and fix the resulting type errors: narrow caught errors via `err instanceof Error`, type the router compat hooks and API response shapes, and add ambient declarations for CSS imports. Signed-off-by: Guillaume Vincent <gvincent@redhat.com>
65a7a6f to
cd303b5
Compare
|
/ok-to-test |
|
/ok-to-test |
|
/lgtm |
|
/approve |
|
All PipelineRuns for this commit have already succeeded. Use |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbaldessari, rh-gvincent The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Set "strict": true in tsconfig.json and fix the resulting type errors: narrow caught errors via
err instanceof Error, type the router compat hooks and API response shapes, and add ambient declarations for CSS imports.